Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for filesystem router #825

Closed
mcollovati opened this issue Aug 4, 2024 · 1 comment · Fixed by #871
Closed

Add support for filesystem router #825

mcollovati opened this issue Aug 4, 2024 · 1 comment · Fixed by #871
Labels
bug Something isn't working released Issue has been released

Comments

@mcollovati
Copy link
Owner

mcollovati commented Aug 4, 2024 •
edited
Loading

Filesystem router is currently half-working. For example, creating the application menu whit Hilla provided feature is not working because RouteUnifyingIndexHtmlRequestListener is not invoked.
@mcollovati mcollovati moved this from 🆕 New to 🔖 Ready in quarkus-hilla backlog Aug 4, 2024
@mcollovati mcollovati changed the title Add E2E tests for RouteUnifyingIndexHtmlRequestListener Add support for filesystem router Aug 21, 2024
@mcollovati mcollovati added bug Something isn't working and removed internal-improvement labels Aug 21, 2024
@mcollovati mcollovati moved this from 🔖 Ready to 🏗 In progress in quarkus-hilla backlog Aug 21, 2024
mcollovati added a commit that referenced this issue Aug 21, 2024
@mcollovati
fix: fix filesystem router support
3e7c4c0 
Adds support for filesystem router by exposing RouteUnifyingServiceInitListener bean.
Also refactors react smoke test to use filesystem router.

Fixes #825
@mcollovati mcollovati mentioned this issue Aug 21, 2024
Merged
mcollovati added a commit that referenced this issue Aug 21, 2024
@mcollovati
fix: fix filesystem router support (#871)
b4ca85b 
Adds support for filesystem router by exposing RouteUnifyingServiceInitListener bean.
Also refactors react smoke test to use filesystem router.

Fixes #825
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in quarkus-hilla backlog Aug 21, 2024
quarkus-hilla-bot bot pushed a commit that referenced this issue Aug 21, 2024
@mcollovati @github-actions
fix: fix filesystem router support (#871)
bb63e2e 
Adds support for filesystem router by exposing RouteUnifyingServiceInitListener bean.
Also refactors react smoke test to use filesystem router.

Fixes #825

(cherry picked from commit b4ca85b)
@quarkus-hilla-bot quarkus-hilla-bot bot mentioned this issue Aug 21, 2024
Merged
mcollovati pushed a commit that referenced this issue Aug 21, 2024
@quarkus-hilla-bot
fix: fix filesystem router support (#871) (CP: 24.4) (#872)
5104bd3 
Adds support for filesystem router by exposing RouteUnifyingServiceInitListener bean.
Also refactors react smoke test to use filesystem router.

Fixes #825

(cherry picked from commit b4ca85b)
@github-actions GitHub Actions
Copy link

This issue has been resolved in 24.4.1 (Release Notes)

@github-actions github-actions bot added the released Issue has been released label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released Issue has been released
Projects
quarkus-hilla backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix filesystem router support mcollovati/quarkus-hilla
1 participant
@mcollovati