Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc12 compilation issues prevent conda deployment #125

Closed
tkittel opened this issue May 16, 2023 · 2 comments
Closed

gcc12 compilation issues prevent conda deployment #125

tkittel opened this issue May 16, 2023 · 2 comments
Assignees
@tkittel
Labels
bug deployment tests unit tests and CI setup

Comments

@tkittel
Copy link
Member

tkittel commented May 16, 2023

Unfortunately we did not have gcc 12 in our unit testing (we do now!), so we missed an annoying compilation error that prevents the conda PR tests from all succeeding, and thus the conda packages for release 3.6.0 from being deployed.

I am trying to make a quick workaround and a release 3.6.1 out the door asap, and then we have to revisit this compilation error after a few weeks when there might be time.
@tkittel tkittel added bug deployment tests unit tests and CI setup labels May 16, 2023
@tkittel tkittel self-assigned this May 16, 2023
tkittel added a commit that referenced this issue Jul 10, 2023
@tkittel
try to debug #125
b1ea30d
@tkittel
Copy link
Member Author

tkittel commented Jul 14, 2023

This will be addressed in the upcoming v3.7.0 release. The aligned allocator was rewritten for better portability (and correctness!), and additionally, the SmallVector::clear method needed to be rewritten in a very specific way before gcc12 would stop giving (wrong!) errors.

@tkittel
Copy link
Member Author

tkittel commented Aug 2, 2023

Fixed in v3.7.0.

@tkittel tkittel closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkittel tkittel

Labels
bug deployment tests unit tests and CI setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkittel