espressif: refactor after removing IDF submodule #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
almir-okato
changed the title
Signed-off-by: Almir Okato <almir.okato@espressif.com>
Remove the ESP-IDF from git submodules to avoid potential duplicated repo clones on the user system. IDF HAL code is still a dependency for Espressif port, therefore now the HAL code reference needs to be passed by parameter when building. The Espressif port was also updated to work with last v5.1 IDF code. Signed-off-by: Almir Okato <almir.okato@espressif.com>
Update the script for cloning and installing Espressif IDF needed for building MCUboot Espressif's port on CI. Signed-off-by: Almir Okato <almir.okato@espressif.com>
Signed-off-by: Almir Okato <almir.okato@espressif.com>
almir-okato
force-pushed
the
esp_remove_idf_submodule
branch
from
60554a3
to
c2a4ff8
Compare
|
@sylvioalves @utzig PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the IDF from gitmodules.
The main reasons for the removal are avoiding to have unnecessary clones from IDF and avoiding system environment conflicts.
Instead of using IDF downloaded as submodule, the Espressif port uses a parameter passed on building as reference for HAL code:
ESP_HAL_PATH- path where are the components used by Espressif port HAL.An existing IDF installation also can be used, so if the parameters are not present when building, the build system will search for IDF_PATH from the environment variables.
Currently, the HAL code expected considers the IDF
release/v5.1branch code basis. As the supported RTOSes get updated with the MCUboot Espressif port expected changes, a check for HAL versions should be add.