boot: zephyr: Add warning on default key file usage #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a warning if one of the default signing/encryption key files is used Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
de-nordic
reviewed
Oct 8, 2024
Comment on lines
+296
to
+304
| set(mcuboot_default_signature_files | ||
| ${MCUBOOT_DIR}/root-ec-p256-pkcs8.pem | ||
| ${MCUBOOT_DIR}/root-ec-p384.pem | ||
| ${MCUBOOT_DIR}/root-ec-p384-pkcs8.pem | ||
| ${MCUBOOT_DIR}/root-ed25519.pem | ||
| ${MCUBOOT_DIR}/root-rsa-2048.pem | ||
| ${MCUBOOT_DIR}/root-rsa-3072.pem | ||
| ${MCUBOOT_DIR}/root-ec-p256.pem | ||
| ) |
There was a problem hiding this comment.
And we will get that one lazy person that just overwrites the key, instead of changing path, and keeps on getting the warning.
Shouldn't we rather hardcode hash of all keys, that we provide with mcuboot, here and compare it to whatever gets assigned as key file and then issue the warning?
Also, in the future, we should rename the keys to something like "NON-PORDUCTION-root-blah.pem" keys...
There was a problem hiding this comment.
Unfortunately not, the actual MD5 of files depends on your git settings, on linux systems they will probably all match, those might differ on mac whereby the line ending was \r instead of \n, and on windows where the line ending is \r\n it will fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a warning if one of the default signing/encryption key files is used