Allow bypassing ASN.1 processing of public key for ED25519 #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds MCUBOOT_KEY_IMPORT_BYPASS_ASN configuration option that allows bypassing ASN.1 decoding of ED25519 public key, compiled into MCUboot. When the option is enabled the key will be accessed directly and ASN.1 processing is not compiled in, resulting in smaller footprint of MCUboot, at a cost of reduced detection of invalid key, i.e. public key designated for different method than compiled in. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 8, 2024
…ey import The commit adds MCUBOOT_KEY_IMPORT_BYPASS_ASN configuration option that allows bypassing ASN.1 decoding of ED25519 public key, compiled into MCUboot. When the option is enabled the key will be accessed directly and ASN.1 processing is not compiled in, resulting in smaller footprint of MCUboot, at a cost of reduced detection of invalid key, i.e. public key designated for different method than compiled in. Upstream PR: mcu-tools/mcuboot#2089 Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 8, 2024
…SS_ASN The option enables MCUboot configuration option MCUBOOT_KEY_IMPORT_BYPASS_ASN. Upstream PR: mcu-tools/mcuboot#2089 Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
nordicjm
reviewed
Oct 9, 2024
nordicjm
changed the title
The option enables MCUboot configuration option MCUBOOT_KEY_IMPORT_BYPASS_ASN. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
ed25519-asn1-bypass
branch
from
1cdb478
to
86e26fa
Compare
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 9, 2024
…ey import The commit adds MCUBOOT_KEY_IMPORT_BYPASS_ASN configuration option that allows bypassing ASN.1 decoding of ED25519 public key, compiled into MCUboot. When the option is enabled the key will be accessed directly and ASN.1 processing is not compiled in, resulting in smaller footprint of MCUboot, at a cost of reduced detection of invalid key, i.e. public key designated for different method than compiled in. Upstream PR: mcu-tools/mcuboot#2089 Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 9, 2024
…SS_ASN The option enables MCUboot configuration option MCUBOOT_KEY_IMPORT_BYPASS_ASN. Upstream PR: mcu-tools/mcuboot#2089 Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
nordicjm
approved these changes
Oct 10, 2024
nvlsianpu
approved these changes
Oct 10, 2024
|
@d3zd3z hej, got time to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conditional compilation of ASN.1 decoding of ED25519 key.
This allows to cut out the ASN.1 encoding, which results in reduced flash size.
Comparison on nrf52840dk/nrf52840 build of MCUboot with the ED25519 enabled
Reduces code from 40422 bytes to 39918 bytes, when
-DCONFIG_BOOT_KEY_IMPORT_BYPASS_ASN=yis added.Another benefit of the option is that it is no longer needed to have portion of the mbedTLS, that does the ASN.1 support, enabled when compiling MCUboot with ED25519 for TinyCrypt.