-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imgtool: bugfix #2096 #2098
Merged
Merged
imgtool: bugfix #2096 #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing broken encryption caused by shift in function parameters. Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no>
@mimok can you try this and check the issue is resolved? |
Actually, I implemented the same thing as a work around. I believe it works (according to the content of the binary file) but i need to do additional tests these friday to see whether mcuboot is ok with binaries generated this way. |
nvlsianpu
approved these changes
Oct 16, 2024
nordicjm
pushed a commit
to nordicjm/sdk-mcuboot
that referenced
this pull request
Oct 16, 2024
fixing broken encryption caused by shift in function parameters. Upstream PR: mcu-tools/mcuboot#2098 Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no>
de-nordic
approved these changes
Oct 16, 2024
nordicjm
pushed a commit
to nrfconnect/sdk-mcuboot
that referenced
this pull request
Oct 17, 2024
fixing broken encryption caused by shift in function parameters. Upstream PR: mcu-tools/mcuboot#2098 Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no>
rlubos
pushed a commit
to rlubos/fw-nrfconnect-mcuboot
that referenced
this pull request
Oct 22, 2024
fixing broken encryption caused by shift in function parameters. Upstream PR: mcu-tools/mcuboot#2098 Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit 31f74eb)
rlubos
pushed a commit
to rlubos/fw-nrfconnect-mcuboot
that referenced
this pull request
Oct 22, 2024
fixing broken encryption caused by shift in function parameters. Upstream PR: mcu-tools/mcuboot#2098 Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit 31f74eb)
jukkar
pushed a commit
to jukkar/sdk-mcuboot
that referenced
this pull request
Dec 5, 2024
fixing broken encryption caused by shift in function parameters. Upstream PR: mcu-tools/mcuboot#2098 Signed-off-by: Mateusz Michalek <mateusz.michalek@nordicsemi.no> (cherry picked from commit 31f74eb) (cherry picked from commit 2b568d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing broken encryption caused by shift in function parameters.
Fixes #2096