Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11 support #56

Merged
merged 14 commits into from
Apr 22, 2024
Merged

Conversation

MartinsRucevskis
Copy link
Contributor

No description provided.

README.md Outdated
@@ -22,7 +22,7 @@ Optionally, you can install Phiremock Server in case you want to have it between
"require-dev": {
"mcustiel/phiremock-codeception-extension": "^2.0",
"mcustiel/phiremock-server": "^1.0",
"guzzlehttp/guzzle": "^6.0"
"guzzlehttp/guzzle": "^7.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.json Outdated
@@ -45,7 +45,7 @@
},
"suggest": {
"mcustiel/phiremock-server": "As a dev-requirement. Allows the extension to start phiremock automatically from vendor/bin",
"guzzlehttp/guzzle" : "Version 6 to execute phiremock-server as default"
"guzzlehttp/guzzle" : "Version 7 to execute phiremock-server as default"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the other comment regarding guzzle.

composer.json Outdated
@@ -33,9 +33,9 @@
"description" : "Codeception extension for Phiremock. Allows to stub remote services for HTTP requests.",
"license" : "GPL-3.0-or-later",
"require" : {
"php" : "^8.0",
"php" : "^8.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have symfony process required as ">=5.0.0 <8.0.0" and keep the php "^8.0" requirement?
This change will require me to release a major version of the extension (v4), and then I would need to maintain v3 and v4, since probably there are still people using php v8.0 and v8.1.

@mcustiel
Copy link
Owner

@MartinsRucevskis Thank you very much for taking the initiative to update the dependencies, please have a look at my comments.

@MartinsRucevskis MartinsRucevskis marked this pull request as draft March 31, 2024 18:49
@MartinsRucevskis MartinsRucevskis marked this pull request as ready for review April 20, 2024 18:55
@MartinsRucevskis
Copy link
Contributor Author

Made the suggested changes, seems to be working fine. Thank You!

README.md Show resolved Hide resolved
@mcustiel
Copy link
Owner

Thank you for taking care of this update @MartinsRucevskis

@mcustiel mcustiel merged commit e75713b into mcustiel:master Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants