-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 11 support #56
Laravel 11 support #56
Conversation
Updated composer.json
updated composer.json package name
…nments Updated scrutinizer environments
README.md
Outdated
@@ -22,7 +22,7 @@ Optionally, you can install Phiremock Server in case you want to have it between | |||
"require-dev": { | |||
"mcustiel/phiremock-codeception-extension": "^2.0", | |||
"mcustiel/phiremock-server": "^1.0", | |||
"guzzlehttp/guzzle": "^6.0" | |||
"guzzlehttp/guzzle": "^7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay in v6, since guzzle v6 is a dependency of phiremock-server: https://github.com/mcustiel/phiremock-server?tab=readme-ov-file#default-installation-through-composer
To use V7, an own implementation of guzzle needs to be provided: https://github.com/mcustiel/phiremock-server?tab=readme-ov-file#overwriting-the-factory-class
composer.json
Outdated
@@ -45,7 +45,7 @@ | |||
}, | |||
"suggest": { | |||
"mcustiel/phiremock-server": "As a dev-requirement. Allows the extension to start phiremock automatically from vendor/bin", | |||
"guzzlehttp/guzzle" : "Version 6 to execute phiremock-server as default" | |||
"guzzlehttp/guzzle" : "Version 7 to execute phiremock-server as default" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the other comment regarding guzzle.
composer.json
Outdated
@@ -33,9 +33,9 @@ | |||
"description" : "Codeception extension for Phiremock. Allows to stub remote services for HTTP requests.", | |||
"license" : "GPL-3.0-or-later", | |||
"require" : { | |||
"php" : "^8.0", | |||
"php" : "^8.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have symfony process required as ">=5.0.0 <8.0.0"
and keep the php "^8.0" requirement?
This change will require me to release a major version of the extension (v4), and then I would need to maintain v3 and v4, since probably there are still people using php v8.0 and v8.1.
@MartinsRucevskis Thank you very much for taking the initiative to update the dependencies, please have a look at my comments. |
Made the suggested changes, seems to be working fine. Thank You! |
Thank you for taking care of this update @MartinsRucevskis |
No description provided.