Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use print() function in both Python 2 and Python 3 #13

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link

@cclauss cclauss commented Oct 21, 2021

Python 2 died 660 days ago on 1/1/2020 so it may no longer be available on modern OSes. Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.

% futurize -f libfuturize.fixes.fix_print_with_import -w .

@mcw0
Copy link
Owner

mcw0 commented Oct 23, 2021

  1. Issues has been disabled for these PoC's, as they are simply PoC, Public Domain and unsupported.
  2. I know python2 is dead, that's why I only write in python3 nowadays
  3. Your print() changes doesn't make my old python2 PoC python3 ported
  4. I would consider to merge your changes of my PoC, if all PoC's been ported to python3

@cclauss
Copy link
Author

cclauss commented Oct 23, 2021

The title of the pr is clear. This PR is not claiming that these files are fully Python 3 compatible. It is only claiming that one of the most tedious and error prone parts of Python 3 porting has been done in a way that does not break compatibility with legacy Python.

I have successfully led the porting of many complex codebases to Python 3 (e.g.: Node.js, InternetArchive/OpenLibrary, etc.) so I know that the port is not automatic and seldom happens in a single pull request except for trivial codebases.

@mcw0
Copy link
Owner

mcw0 commented Oct 23, 2021

From 'we' to 'I'... I noted all forks() and PR's been done in other repos, that makes me wonder what mission you may have?

Listen, I appreciate the work that has been done, but w/o full port to python3 and verified with PoC target (or python2 bug fixes), I will not accept PR, sorry. I'll keep this open for a while tough.

@cclauss cclauss closed this Oct 23, 2021
@cclauss cclauss deleted the print_function branch October 23, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants