Increase bindgen dependency lower bound #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase to 0.63. This value was chosen because it is known to succeed in Fedora rawhide and Fedora 38. 0.59.0 bindgen now fails with the following error on these platforms: process didn't exit successfully: `/__w/libcryptsetup-rs/libcryptsetup-rs/target/debug/build/loopdev-cd83fd54aaebcba7/build-script-build` (exit status: 101) --- stderr thread 'main' panicked at '"enum_(unnamed_at_/usr/include/linux/loop_h_16_1)" is not a valid Ident', /github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.56/src/fallback.rs:811:9 Signed-off-by: mulhern <amulhern@redhat.com>
|
It looks like an increase to 0.62.0 would be enough to fix the FTBFS on f38: stratis-storage/project#589 (comment) . @mdaffin Would you consider accepting this upgrade to bindgen dependency and making a new release of loopdev? If 0.63.0 is too high for some purpose, then 0.62.0 would still work. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase to 0.63. This value was chosen because it is known to succeed in Fedora rawhide and Fedora 38.
0.59.0 bindgen now fails with the following error on these platforms:
process didn't exit successfully:
/__w/libcryptsetup-rs/libcryptsetup-rs/target/debug/build/loopdev-cd83fd54aaebcba7/build-script-build(exit status: 101)--- stderr
thread 'main' panicked at '"enum_(unnamed_at_/usr/include/linux/loop_h_16_1)" is not a valid Ident', /github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.56/src/fallback.rs:811:9