Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar uses media queries with hard coded width instead of bootstrap's variables @screen-* #352

Closed
guymguym opened this issue Jan 9, 2015 · 3 comments

Comments

@guymguym
Copy link

guymguym commented Jan 9, 2015

for example in _navbar.less it uses @media (max-width: 767px) and @media (max-width: 1199px) which can easily be replaced with @screen-sm and @screen-lg respectively...

this will allow changing to custom app values.

thanks!

@FezVrasta
Copy link
Contributor

the problem is that this theme doesn't compile along with the bootstrap source. it overrides the theme, so it has no access to the bootstrap variables.

@guymguym
Copy link
Author

guymguym commented Jan 9, 2015

I see. maybe best way to co-exist is to provide these @screen-* variables with default values and if bootstrap is imported or other less file of the application overrides it will take the latest value?
as suggested here less/less.js#1706 it can be done like this:

.my-library-defaults() {
    @a: 1;
    @b: 2;
    // etc.
} .my-library-defaults();

@rosskevin
Copy link
Contributor

closing in lieu of #727, which aims at reuse/import of basic bootstrap variables

rosskevin added a commit that referenced this issue Nov 21, 2015
FezVrasta pushed a commit that referenced this issue Apr 6, 2017
FezVrasta pushed a commit that referenced this issue Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants