Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate prototype pollution effects #601

Merged
merged 2 commits into from
May 31, 2021
Merged

Mitigate prototype pollution effects #601

merged 2 commits into from
May 31, 2021

Commits on May 30, 2021

  1. Sanitize option names.

    This prevents injection of arbitrary code if the server is already
    vulnerable to prototype poisoning. This resolves mde#451.
    
    I deliberately opted to not support complex Unicode identifiers even
    though they're valid JS identifiers. They're complex to validate and
    users probably shouldn't even try to be that creative.
    nicdumz committed May 30, 2021
    Configuration menu
    Copy the full SHA
    15ee698 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. Create Objects without prototypes.

    This generally helps mitigate prototype pollution: even if another
    library allows prototype pollution, ejs will not allow escalating this
    into Remote Code Execution.
    nicdumz committed May 31, 2021
    Configuration menu
    Copy the full SHA
    be9a9bb View commit details
    Browse the repository at this point in the history