-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify ESLint configurations #761
base: version-4
Are you sure you want to change the base?
Conversation
This is amazing! Some notes: Use of
|
Also adding you as a contributor to make this easier. これからもよろしくお願いいたします! |
@mde Thank you for the review!
Thank you, こちらこそよろしくお願いします! |
Sorry for the delay.
The link didn't work unfortunately, but did you mean this? var d = require('domain').create(); Yes, I forgot to replace inline
That makes sense. I will revert the test code to CommonJS and consider if we can use a single eslint.config.js without entirely migrating to ESM. |
…e#766) The async option description in the documentation was missing a closing parenthesis. This commit adds the closing parenthesis to correctly complete the sentence.
Support for Node.js v8, v10, and v12 are removed and replaced with v18, v20, v21, and v22.
This is not breaking change because `engine-strict` is not set in .npmrc and npm only warns if the user uses legacy Node.js versions.
lib/cjs/ includes build output.
In this file, both `readFileSync()` and an alias `read()` are used. You can't do this after migration to ESM.
Style-related ESLint rules are purged from ESLint and replaced with ESLint Stylistic.
Because Jake's build process does not fail when ESLint reports errors.
fixup! Update package-lock.json
WIP: This PR depends on #760. I will rebase this branch after #760 is merged.
Currently, the commits in this PR are a bit unreadable because it includes commits in #760, so please start reviewing after I make this PR ready to be reviewed.