Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove direct refs to homeassistant.helpers when HA >= 2024.6 #231

Merged
merged 1 commit into from
Jul 30, 2024
Merged

remove direct refs to homeassistant.helpers when HA >= 2024.6 #231

merged 1 commit into from
Jul 30, 2024

Conversation

DerekF35
Copy link
Contributor

Closes #229
Apprach taken from custom-components/ble_monitor@a95ae14

@DerekF35 DerekF35 requested a review from mdeweerd as a code owner June 11, 2024 01:18
@DerekF35 DerekF35 mentioned this pull request Jun 11, 2024
Closed
wbyoung
wbyoung approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@wbyoung wbyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable solution to me. However, like you, I don't do much coding with HA core, so my review is more like a sanity check.

CordoWEB
CordoWEB approved these changes Jun 11, 2024
View reviewed changes
Copy link

@CordoWEB CordoWEB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is working fine with this patch but i do not know if it is the best practices :)
Tested on HA 2024.6.2.

@CordoWEB CordoWEB mentioned this pull request Jun 11, 2024
Closed
@BenchPressesBooks BenchPressesBooks mentioned this pull request Jun 13, 2024
Closed
Teagan42
Teagan42 approved these changes Jun 21, 2024
View reviewed changes
Copy link

@Teagan42 Teagan42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking changes, simply suggestion based on the patterns in HA core:
https://github.com/home-assistant/core/blob/2ad5b1c3a6140a49d1113e86e46b68165cf26884/homeassistant/helpers/device.py#L5
https://github.com/home-assistant/core/blob/2ad5b1c3a6140a49d1113e86e46b68165cf26884/homeassistant/auth/permissions/models.py#L10
https://github.com/home-assistant/core/blob/2ad5b1c3a6140a49d1113e86e46b68165cf26884/homeassistant/components/nest/__init__.py#L49

custom_components/zha_toolkit/utils.py Outdated Show resolved Hide resolved
custom_components/zha_toolkit/utils.py Outdated Show resolved Hide resolved
custom_components/zha_toolkit/utils.py Outdated Show resolved Hide resolved
custom_components/zha_toolkit/utils.py Outdated Show resolved Hide resolved
custom_components/zha_toolkit/utils.py Outdated Show resolved Hide resolved
custom_components/zha_toolkit/utils.py Outdated Show resolved Hide resolved
custom_components/zha_toolkit/utils.py Outdated Show resolved Hide resolved
custom_components/zha_toolkit/utils.py Outdated Show resolved Hide resolved
@DerekF35
Copy link
Contributor Author

@Teagan42 Ah yes, that is much simpler and cleaner. I've made the code changes locally and everything is still in working order. I've repushed after updating with your suggestions.

@clarkewing
Copy link

@mdeweerd any timeline on a merge?

@paulvt paulvt mentioned this pull request Jul 12, 2024
Closed
@wbyoung
Copy link
Contributor

wbyoung commented Jul 12, 2024

I finally got tired of waiting for this to be merged & released and patched my install. I can confirm that it's working well for me as well.

@macecchi
Copy link

I can confirm this fix works here too. I'm on HA 2024.6.4.

@owpac
Copy link

owpac commented Jul 24, 2024 •
edited
Loading

Hello, same problem for me. The fix work locally too. Would be better if this was merged tho 🙏

@mdeweerd mdeweerd merged commit 33e948b into mdeweerd:main Jul 30, 2024
@mdeweerd
Copy link
Owner

Hello everybody

Sorry for my absence on github - I've been very busy and I had to drop some activities.

I am looking into the PRs and integrate them in the main branch.

@CordoWEB
Copy link

Tu es excusé :)
Si tu as besoin d'aide je peux potentiellement le faire. Webmaster et développeur C# à mes heures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbyoung wbyoung wbyoung approved these changes

@Teagan42 Teagan42 Teagan42 approved these changes

@CordoWEB CordoWEB CordoWEB approved these changes

@mdeweerd mdeweerd Awaiting requested review from mdeweerd mdeweerd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: async_get() takes 1 positional argument but 2 were given
8 participants
@DerekF35 @clarkewing @wbyoung @macecchi @owpac @mdeweerd @CordoWEB @Teagan42