Fix issues accessing the ZHA gateway #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gateway could now also be a gateway proxy object that stores the HASS object under `hass` instead of `_hass` and the HASS object is no longer available in the non-proxy object since it lives in the new ZHA (non-HA) library. Having access to the proxy object is useful to get the `hass` object, but accessing the application controller needs to be done through the actual gateway. Therefore, a helper method has been added with simple duck-type checking to reach the gateway through the `gateway` property of the proxy. Fixes: mdeweerd#251
|
Hello. Can you test that ? I am setting up a third home-assistant (I have two locations) so that I can test the latest version with a gateway without breaking the operationnal versions - I had to hack a device for that first. |
|
#253 was merged, so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gateway could now also be a gateway proxy object that stores the HASS object under
hassinstead of_hassand the HASS object is no longer available in the non-proxy object since it lives in the new ZHA (non-HA) library.Having access to the proxy object is useful to get the
hassobject, but accessing the application controller needs to be done through the actual gateway. Therefore, a helper method has been added with simple duck-type checking to reach the gateway through thegatewayproperty of the proxy.Fixes: #251