Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inline import and sync file io raising hass warnings #280

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Fix inline import and sync file io raising hass warnings #280

merged 4 commits into from
Jan 6, 2025

Conversation

chenseanxy
Copy link
Contributor

This fixes #279

@chenseanxy chenseanxy requested a review from mdeweerd as a code owner January 6, 2025 08:17
@mdeweerd
Copy link
Owner

mdeweerd commented Jan 6, 2025

@chenseanxy I applied pre-commit, and fixed how the const import is used.

mypy reports a typing mismatch in json.load().

These changes were pushed to your branch.

@chenseanxy
Copy link
Contributor Author

My bad, forgot to upstream changes I made in my hass instance.. Should be fixed now.

@mdeweerd mdeweerd merged commit da2bf33 into mdeweerd:main Jan 6, 2025
4 checks passed
@mdeweerd
Copy link
Owner

mdeweerd commented Jan 6, 2025

Great that it was already fixed locally!
I made pre-release v1.1.25.

@chenseanxy chenseanxy deleted the fix-async-fileio branch January 6, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeweerd mdeweerd Awaiting requested review from mdeweerd mdeweerd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In-line imports during znp_backup
2 participants
@chenseanxy @mdeweerd