Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signature of modular to return Int instead of Float #183

Closed
wants to merge 1 commit into from
Closed

Change signature of modular to return Int instead of Float #183

wants to merge 1 commit into from

Conversation

jcornaz
Copy link

@jcornaz jcornaz commented Mar 11, 2020

So that it behaves as claimed by the documentation

Resolves #36

So that it behaves as claimed by the documentation
@andreacfromtheapp
Copy link

this is not the issue. the type annotation is correct.

see: #36 (comment) and #331

@jcornaz
Copy link
Author

jcornaz commented Jan 8, 2022

I'm surprised by this statement. But I don't use elm anymore, so I will not spend time trying to verify your claim.

And anyway, after almost two years without any message of the maintener in either the issue or this PR, I think it is time for me to close this.

@jcornaz jcornaz closed this Jan 8, 2022
@andreacfromtheapp
Copy link

I'm surprised by this statement. But I don't use elm anymore, so I will not spend time trying to verify your claim.

And anyway, after almost two years without any message of the maintener in either the issue or this PR, I think it is time for me to close this.

that's understandable. thanks closing the issue on trust (or because you are pissed).

@jcornaz
Copy link
Author

jcornaz commented Jan 8, 2022

It's not really on trust. And I am not pissed either. It is just obvious by now, that the maintener is not interested in this issue, and it will not advance anytime soon.

But more importantly, even if it would gain sudden activity, I am no longer offering my contribution (either in form of code or discussion) because I moved on other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element.modular returns Float but Font.size requires Int
2 participants