Improve behaviour of SetReadBuffer / SetWriteBuffer #165
Conversation
|
Hey, my apologies for the delay here, I totally lost track of this. I will review now. |
| bytes, | ||
| )) | ||
| if err != nil { | ||
| // If SO_SNDBUFFORCE fails, try SO_RCVBUF |
There was a problem hiding this comment.
Is there a specific syscall error we could inspect to determine if fallback is needed? Would something like os.IsPermission be sufficient?
There was a problem hiding this comment.
The man page does not require a specific error for that case, but the kernel uses EPERM (which is the only logical one of course). Also the permission check is the first thing to happen. I don't think it will ever make a difference if we check for permission errors or not, libnfnetlink does not check for it. Your choice.
There was a problem hiding this comment.
I'm good with leaving it be then, thanks for the info.
|
Thank you for your review. I adressed your remarks. |
| bytes, | ||
| )) | ||
| if err != nil { | ||
| // If SO_SNDBUFFORCE fails, try SO_RCVBUF |
There was a problem hiding this comment.
I'm good with leaving it be then, thanks for the info.
(see issue #164 for a detailed explanation)
This PR allows users to use their privileges regarding buffer sizes: root and users with
CAP_NET_ADMINcan ignore the system's limit on buffer sizes. Unprivileged users are not affected, there's a fallback. The testcase has been adjusted.While I was working on this PR I noticed that the library has no method to read back the actual buffer size of the socket. I added these methods (
GetReadBufferandGetWriteBuffer) which are similar to their Write pendants.