implement signed integer encoding/decoding #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to be able to talk to the netlink link XDP API. https://github.com/jsimonetti/rtnetlink/blob/bde56ed1639131dc68895fd3b0e574a85720cd09/link.go#L563 https://github.com/fbegyn/rtnetlink/blob/link-xdp-patch/link.go#L565 https://elixir.bootlin.com/linux/v5.10.15/source/net/core/rtnetlink.c#L2911
|
Thanks for this! I will try to take a look later today. |
mdlayher
requested changes
Feb 23, 2021
attribute.go
Outdated
| } | ||
|
|
||
| b := make([]byte, 2) | ||
| ae.ByteOrder.PutUint16(b,uint16(v)) |
attribute_test.go
Outdated
| @@ -909,18 +983,18 @@ func TestAttributeEncoderOK(t *testing.T) { | |||
| }, | |||
| }, | |||
| { | |||
| name: "uint native endian", | |||
| name: "uint-int32 native endian", | |||
There was a problem hiding this comment.
Just "int" for all these cases, not int32.
Seems like my auto gofmt didn't trigger on some parts.
As the `nlenc` module is deprecated, new tests and features should not be introduced to it.
|
With the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #184 by implementing the signed integer encoders and decoders.
The
int(uint(is not necessarily pretty, but the other options to my knowledge are:nlenc)