Ensure a minimum of 32KB for the buffer used in recvmsg() #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See iproute2 commit bb5ae621d0c7 ("lib/libnetlink: ensure a minimum of
32KB for the buffer used in rtnl_recvmsg()").
iproute2/iproute2@bb5ae621d0c7
Linux v4.9 and newer contains the two commits mentioned in the above
commit message:
"See kernel commits 9063e21fb026 ("netlink: autosize skb lengthes") and
d35c99ff77ec ("netlink: do not enter direct reclaim from netlink_dump()")
for more details."
Also, use unix.MSG_TRUNC to peek without copying the actual payload.
Related to issues mdlayher#178.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See iproute2 commit bb5ae621d0c7 ("lib/libnetlink: ensure a minimum of 32KB for the buffer used in rtnl_recvmsg()").
iproute2/iproute2@bb5ae621d0c7
Linux v4.9 and newer contains the two commits mentioned in the above commit message:
"See kernel commits 9063e21fb026 ("netlink: autosize skb lengthes") and d35c99ff77ec ("netlink: do not enter direct reclaim from netlink_dump()") for more details."
Also, use unix.MSG_TRUNC to peek without copying the actual payload.
Related to issues #178.