Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webextensions.manifest.theme tab_background_separator and toolbar_field_separator should be marked as deprecated in Firefox 89 #22215

Closed
rpl opened this issue Feb 13, 2024 · 3 comments · Fixed by #22216 or #23494
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions

Comments

@rpl
Copy link
Member

rpl commented Feb 13, 2024

What type of issue is this?

Incorrect support data (example: BrowserX says "86" but support was added in "40")

What information was incorrect, unhelpful, or incomplete?

The two theme properties named tab_background_separator and toolbar_field_separator have been both deprecated in Firefox 89 (see blog post https://blog.mozilla.org/addons/2021/04/19/changes-to-themeable-areas-of-firefox-in-version-89/), changes to the MDN content were tracked by mdn/content#4390 and that has been already merged some time ago (and so the MDN docs highlight that these two properties have been deprecated), but the compat data has not been updated yet and so the compatibility table still show both as supported in Firefox.

What browsers does this problem apply to, if applicable?

Firefox

What did you expect to see?

The compatibility table below the MDN page at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme#browser_compatibility should show tab_background_separator and toolbar_field_separator as not suported (and optionally point to the blogpost for more details about their deprecation)

Did you test this? If so, how?

This was a change that was expected to be part of the followups of the Firefox 89 restyling (codenamed Proton), it was tracked on bugzilla by Bug 1705792 and I noticed the inconsistency while retriaging the bug. The blog post we published at the time also mention these two theme properties as deprecated: https://blog.mozilla.org/addons/2021/04/19/changes-to-themeable-areas-of-firefox-in-version-89/.

Can you link to any release notes, bugs, pull requests, or MDN pages related to this?

Do you have anything more you want to share?

No response

MDN URL

No response

MDN metadata

No response

@queengooborg queengooborg added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Feb 14, 2024
queengooborg added a commit to queengooborg/browser-compat-data that referenced this issue Jun 21, 2024
This PR removes the unsupported subfeatures of the `theme` Web Extensions manifest property from BCD. Per the [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#removal-of-irrelevant-features), this feature can be considered irrelevant and may be removed from BCD accordingly.  Fixes mdn#22215.
@rebloor
Copy link
Collaborator

rebloor commented Jun 24, 2024

@Rob--W should we also remove the documentation from MDN?

@Rob--W
Copy link
Member

Rob--W commented Jun 24, 2024

@Rob--W should we also remove the documentation from MDN?

Let's start by clearly marking them as deprecated. The advantage of keeping them documented is that people who encounter them in old themes can try to understand what it did in order to know how to update the theme for the latest Firefox.

@rebloor
Copy link
Collaborator

rebloor commented Jun 25, 2024

Thanks @Rob--W we are good then, as they are noted already:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
4 participants