Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compat info for lab(), lch(), color() #10658

Closed
wants to merge 3 commits into from
Closed

Conversation

LeaVerou
Copy link
Contributor

@LeaVerou LeaVerou commented May 28, 2021

Summary

I used "TP" for features that are in Safari TP and have not yet shipped. I also asked here.
Note that Safari 10 only supported color(display-p3). The other predefined color spaces were added recently and are still in TP. We can iterate on breaking this down in future PRs.

Test results and supporting details

Testcase for color(display-p3)

https://webkit.org/blog/11555/release-notes-for-safari-technology-preview-121/
https://webkit.org/blog/11548/release-notes-for-safari-technology-preview-120/
https://webkit.org/blog/7477/new-web-features-in-safari-10-1/#:~:text=css%20wide-gamut%20colors

Related issues

I used `"TP"` for features that are in Safari TP and have not yet shipped. I also asked [here](mdn#2991 (comment)).
Note that Safari 10 only supported color(display-p3). The other predefined color spaces were added recently and are still in TP. We can iterate on breaking this down in future PRs.
@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label May 28, 2021
@lukewarlow
Copy link
Contributor

With regards to the "TP" designation, #10334 will be of interest to you. From what I gather the exact value to use has not be decided but might be "preview". However, for now I believe the correct value would be false as it's not supported by a stable Safari.

@LeaVerou LeaVerou marked this pull request as draft May 28, 2021 16:27
@LeaVerou
Copy link
Contributor Author

Thank you. I would not want these to be merged as false, as this gives developers an erroneous idea about the state of these features. Therefore, I converted the PR to a draft for now and will monitor the PR you linked to.

css/types/color.json Outdated Show resolved Hide resolved
css/types/color.json Outdated Show resolved Hide resolved
LeaVerou and others added 2 commits May 29, 2021 06:25
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@queengooborg queengooborg added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Jul 27, 2021
@ddbeck ddbeck added rebase needed 🚧 and removed not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels Aug 18, 2021
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LeaVerou, since #10334 has been merged, we can support Safari TP with the new "preview" value. Some merge conflicts have appeared however. If you could rebase and resolve the conflicts, this ought to be able to progress. Thank you!

@LeaVerou LeaVerou marked this pull request as ready for review August 18, 2021 16:58
@LeaVerou
Copy link
Contributor Author

I see that meanwhile, Safari 15 beta got released including this functionality, so someone else has added it. Exciting! Will go ahead and close this PR.

@LeaVerou LeaVerou closed this Aug 18, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Aug 19, 2021

Thanks for this PR and tidying up here, @LeaVerou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants