XRView.isFirstPersonObserver is always false in Chromiums #11809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
Elchi3
force-pushed
the
xrview-ifpo-false
branch
from
7946e1d to
2a561a8
Compare
|
Looking at the spec the observer views are for Secondary Views rendered such that they can be displayed in 2D for a 3rd party. Such as on a near by computer computer monitor or shared with someone. I'm not sure Samsung Internet supports rendering to a secondary view it is not something I've tried but I thought it was a feature implemented on headset based experiences. https://immersive-web.github.io/webxr-ar-module/#first-person-observer-view |
|
Thanks Ada, I think a note like proposed in this PR seems enough then. It is just a heads-up to folks looking into this and always getting back |
ddbeck
requested changes
Nov 1, 2021
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dominiccooney mentioned this in mdn/content#7276 (comment)
See https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/xr/xr_view.h;l=47
I'm not sure if Samsung Internet implements this. Assuming no for now, but cc @AdaRoseCannon.
Also, I guess we can argue if we should set the partial implementation flag to true here (making the table cell rendered yellow).