Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data for BeforeInstallPrompt event #12856

Merged
merged 7 commits into from
Nov 30, 2021
Merged

Update data for BeforeInstallPrompt event #12856

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dffbaf0
Add Chromium versions for api.Window.onbeforeinstallprompt
queengooborg Oct 14, 2021
1c7bae6
Add beforeinstallprompt_event
queengooborg Oct 22, 2021
036944e
Add description
queengooborg Oct 22, 2021
429d5af
Add spec URLs
queengooborg Oct 23, 2021
445772d
Remove spec URLs
queengooborg Nov 28, 2021
0325fd2
Correct versions
queengooborg Nov 30, 2021
36d9558
Update BeforeInstallPromptEvent API
queengooborg Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 54 additions & 6 deletions api/Window.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,54 @@
}
}
},
"beforeinstallprompt_event": {
"__compat": {
"description": "<code>beforeinstallprompt</code> event",
"support": {
"chrome": {
"version_added": "45"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given #7844 I especially distrust Chrome 45 values so I dug deeper.

The feature was enabled by https://chromium.googlesource.com/chromium/src/+/e9e94d1355522e4e4a5a8aa2f540d265130ab98c which via https://www.chromium.org/developers/calendar maps to Chrome 44, although it's so close to the branch date it could have been 45.

But I've also tested logging BeforeInstallPromptEvent in BrowserStack, and can see that it was introduced in Chrome 44.

Can you update the data for BeforeInstallPromptEvent to 44 and also update this to match?

},
"chrome_android": {
"version_added": "45"
},
"edge": {
"version_added": "≤79"
},
"firefox": {
"version_added": false
},
"firefox_android": {
"version_added": false
},
"ie": {
"version_added": false
},
"opera": {
"version_added": "32"
},
"opera_android": {
"version_added": "32"
},
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": {
"version_added": "5.0"
},
"webview_android": {
"version_added": "45"
}
},
"status": {
"experimental": false,
"standard_track": false,
"deprecated": false
}
}
},
"beforeprint_event": {
"__compat": {
"description": "<code>beforeprint</code> event",
Expand Down Expand Up @@ -3914,10 +3962,10 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Window/onbeforeinstallprompt",
"support": {
"chrome": {
"version_added": true
"version_added": "61"
},
"chrome_android": {
"version_added": true
"version_added": "61"
},
"edge": {
"version_added": "≤79"
Expand All @@ -3932,10 +3980,10 @@
"version_added": false
},
"opera": {
"version_added": true
"version_added": "48"
},
"opera_android": {
"version_added": true
"version_added": "45"
},
"safari": {
"version_added": false
Expand All @@ -3944,10 +3992,10 @@
"version_added": false
},
"samsunginternet_android": {
"version_added": true
"version_added": "8.0"
},
"webview_android": {
"version_added": true
"version_added": "61"
}
},
"status": {
Expand Down