Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds Element.isVisible #16473

Closed
wants to merge 3 commits into from
Closed

adds Element.isVisible #16473

wants to merge 3 commits into from

Conversation

rachelandrew
Copy link
Collaborator

Element.isVisible is in Chrome 103. This PR adds BCD.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 30, 2022
queengooborg
queengooborg requested changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this! We recently added a feature that allows derivative browsers to mirror from their upstream counterparts. Let's utilize it here, if that sounds good (this applies to all other PRs as well)!

api/Element.json Outdated Show resolved Hide resolved
@foolip
Copy link
Contributor

foolip commented Jun 2, 2022

w3c/csswg-drafts#7317 resolved to rename this to isHidden.

@rachelandrew
Copy link
Collaborator Author

@foolip I'll update it when I do the other change

@queengooborg
Copy link
Contributor

It looks like this has been renamed to isHidden in the spec, and it has not been included in Chrome 103 with either name. I'm going to mark this as a draft since no implementation has been made in any browser yet.

@queengooborg queengooborg marked this pull request as draft July 8, 2022 08:33
@foolip
Copy link
Contributor

foolip commented Jul 8, 2022

It was actually renamed to checkVisibility in the end.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg
Copy link
Contributor

Alright, since there's no implementation and the spec has been renaming this, I think we should wait until a browser has implemented this before creating a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg requested changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachelandrew @foolip @queengooborg