Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add popover-open selector #19358

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Conversation

keithamus
Copy link
Contributor

Summary

This compat data for the :popover-open psuedo selector.

Test results and supporting details

This is available in the specification: https://developer.mozilla.org/docs/Web/CSS/:popover-open

Related issues

mdn/content#25125

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Apr 12, 2023
@queengooborg
Copy link
Contributor

Hey @keithamus, thank you for tackling this one!

Giving a quick check of the data, it's looking good to me, however it looks like there's a formatting issue. We use two spaces for indentation rather than four in this repository. Would you be down to tweak that real quick?

@keithamus
Copy link
Contributor Author

I've re-indented it 👍

Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick updates! Just one last a little change, and this will be good to go!

css/selectors/popover-open.json Show resolved Hide resolved
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes, LGTM!

@queengooborg queengooborg merged commit b6a0faa into mdn:main Apr 20, 2023
@keithamus keithamus deleted the add-popover-open-selector branch April 20, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants