-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify devtools.panels.create() path resolution #20617
Clarify devtools.panels.create() path resolution #20617
Conversation
I can take a look on Monday if that's okay? Set myself as a reviewer so I don't forget about it. |
Thanks @bsmth |
Noting that |
"support": { | ||
"chrome": { | ||
"version_added": true, | ||
"notes": "URL always resolved as absolute." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestion in the related PR states this may also be relative to the extension directory and the extensions docs say a URL "relative to the extension directory"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsmth within the context of a web extension they are the same thing e.g. "you can specify the path as an absolute URL, starting at the extension's root, like this: /path/to/stylesheet.css
" e.g. the extension root is the starting point. Hence we have statements such as "When a content script makes an HTTP(S) request, you must provide absolute URLs." in the web extensions docs.
Probably "should be" (given that Firefox for Android will almost certainly never support devtools.) However, you can't make that change because the linter considers it to be an error:
|
You're right, I guess we're forced to mirror unless there is support in Firefox and a need to disambiguate. edit: this lives here btw: https://github.com/mdn/browser-compat-data/blob/main/test/linter/test-mirror.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! Merging shortly 👍🏻
Summary
Adds browser variation clarifications originally proposed in mdn/content#20552