Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for StorageQuota #2106

Merged
merged 2 commits into from
Aug 21, 2018
Merged

Conversation

bunnybooboo
Copy link
Contributor

@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 22, 2018
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the W3C spec, it looks like this is deprecated now? https://w3c.github.io/quota-api/#widl-Navigator-storageQuota

Copy link
Contributor

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the data here has problems that should be checked before we merge, also it needs an update now that the API is deprecated.

"version_added": "55"
},
"chrome": {
"version_added": "55"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status page seems to suggest that the API was implemented in Chrome 14, do you have a reason to believe otherwise? https://www.chromestatus.com/feature/6218562888794112

"chrome_android": {
"version_added": "55"
},
"edge": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any evidence that Edge ever implemented this API

@Elchi3 Elchi3 added this to the Sprint 3 Q3 2018 milestone Aug 7, 2018
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bunnybooboo and thanks for the review @connorshea 👍

@Elchi3 Elchi3 merged commit 992f6d7 into mdn:master Aug 21, 2018
foolip added a commit that referenced this pull request Mar 15, 2021
This was added in #2106
with reference to https://www.chromestatus.com/feature/6218562888794112.

However, it looks like this part of the API was never enabled, and it was
removed from Chromium in 2017:
https://chromium.googlesource.com/chromium/src/+/5fb4064595996e5f0ae942d928e3bccc5209bca7

Note that the entry point, `navigator.storageQuota`, isn't in BCD.
@foolip foolip mentioned this pull request Mar 15, 2021
Elchi3 pushed a commit that referenced this pull request Mar 15, 2021
This was added in #2106
with reference to https://www.chromestatus.com/feature/6218562888794112.

However, it looks like this part of the API was never enabled, and it was
removed from Chromium in 2017:
https://chromium.googlesource.com/chromium/src/+/5fb4064595996e5f0ae942d928e3bccc5209bca7

Note that the entry point, `navigator.storageQuota`, isn't in BCD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants