-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat data for StorageQuota #2106
Conversation
api/StorageQuota.json
Outdated
"status": { | ||
"experimental": true, | ||
"standard_track": true, | ||
"deprecated": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the W3C spec, it looks like this is deprecated now? https://w3c.github.io/quota-api/#widl-Navigator-storageQuota
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the data here has problems that should be checked before we merge, also it needs an update now that the API is deprecated.
api/StorageQuota.json
Outdated
"version_added": "55" | ||
}, | ||
"chrome": { | ||
"version_added": "55" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The status page seems to suggest that the API was implemented in Chrome 14, do you have a reason to believe otherwise? https://www.chromestatus.com/feature/6218562888794112
api/StorageQuota.json
Outdated
"chrome_android": { | ||
"version_added": "55" | ||
}, | ||
"edge": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any evidence that Edge ever implemented this API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bunnybooboo and thanks for the review @connorshea 👍
This was added in #2106 with reference to https://www.chromestatus.com/feature/6218562888794112. However, it looks like this part of the API was never enabled, and it was removed from Chromium in 2017: https://chromium.googlesource.com/chromium/src/+/5fb4064595996e5f0ae942d928e3bccc5209bca7 Note that the entry point, `navigator.storageQuota`, isn't in BCD.
This was added in #2106 with reference to https://www.chromestatus.com/feature/6218562888794112. However, it looks like this part of the API was never enabled, and it was removed from Chromium in 2017: https://chromium.googlesource.com/chromium/src/+/5fb4064595996e5f0ae942d928e3bccc5209bca7 Note that the entry point, `navigator.storageQuota`, isn't in BCD.
https://developer.mozilla.org/en-US/docs/Web/API/StorageQuota