Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GPUCommandEncoder.writeTimestamp #22709

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Mar 26, 2024

(I was a bit too quick with merging #22608)

See gpuweb/gpuweb#4370

I think what needs to happen here is also:

  • status: deprecated, non-standard and no longer experimental
  • Remove web-features tag given this method is no longer needed to have a full WebGPU implementation. (cc @foolip, @ddbeck)

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 26, 2024
@@ -829,14 +829,10 @@
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/GPUCommandEncoder/writeTimestamp",
"spec_url": "https://gpuweb.github.io/gpuweb/#dom-gpucommandencoder-writetimestamp",
"tags": [
"web-features:webgpu"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This clearly shows the benefit of maintaining the mapping with tags in BCD 👍

"support": {
"chrome": {
"version_added": "113",
"version_removed": "121",
"notes": "Currently supported on ChromeOS, macOS, and Windows only."
"version_removed": "121"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foolip foolip merged commit 05fc7a2 into mdn:main Mar 27, 2024
5 checks passed
@Elchi3 Elchi3 deleted the deprecate-writetimestamp branch March 27, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants