-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WKWebView to BCD #23747
Add WKWebView to BCD #23747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about version. My iPad with iOS 17.5.1 reports version 605.1.15 as you can see in openwebdocs/mdn-bcd-results#1164. This does not really map out to the engine versions for Safari here.
That's because the user agent string was frozen at that time, so it always reports WebKit "605" now, despite it being a much newer version of WebKit. This is the case for Safari Desktop and Safari iOS too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. However, prior to adding this, I would like to know how many values we would record that aren't "mirror". Do we have a collector run to assess that?
Here's a file that contains the changes made by |
Thanks @queengooborg!! This get us 179 features that are not supported Do we know if these findings are correct? @NiklasMerz @RupertBenWiser @jdatapple If so, I think I'm fine with proceeding to add Output of List
|
Given I don't have experience in WKWebView, I just created an emulator on my macbook and verified that the results you flagged were not supported in an emulator, but were in safari. The only issue I flagged was that on my ios 17.5.1 device, Would love to hopefully get @jdatapple 's eyes on this before landing. |
Co-authored-by: Florian Scholz <fs@florianscholz.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this! Given we are able to maintain this data using the OWD collector and BCD already has the android webview data, too, it seems reasonable to also maintain webview_ios data. The 179 features that are not supported webview_ios but are supported in safari_ios are particularly interesting to caniwebview.com and other consumers.
After this PR lands, I expect to see a PR that runs the migration and a collector run for webview_ios.
This PR adds WKWebView to BCD, which fixes #23296. The data will be set to mirror for all features at first, which will occur in a follow-up PR.