Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdn_urls for PaintRenderingContext2D #23850

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jul 18, 2024

PaintRenderingContext2D has the same members as https://developer.mozilla.org/docs/Web/API/CanvasRenderingContext2D and so they are all documented under CanvasRenderingContext2D. The mdn_url linter cannot know about this, so I'm adding these mdn_urls manually.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 18, 2024
@Josh-Cena
Copy link
Member

FYI there is mdn/content#33681. Maybe we should just document it instead, since the sidebar link is also broken?

@Elchi3
Copy link
Member Author

Elchi3 commented Jul 19, 2024

The PaintRenderingContext2D interface itself should have an MDN page (I'm not adding an mdn_url for it), but I think the members don't need to be documented again. At least that's how it is done for https://developer.mozilla.org/en-US/docs/Web/API/OffscreenCanvasRenderingContext2D as well.

@queengooborg queengooborg merged commit 1ccba08 into mdn:main Jul 19, 2024
5 checks passed
@Elchi3 Elchi3 deleted the mdn-urls-paintrendering branch July 19, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants