Update Chromium data for tabs Web Extensions interface #23892
Conversation
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `tabs` Web Extensions interface. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD. Commit/PR Adding the Feature: mdn#512, mdn#469, mdn#446
queengooborg
added
the
data:webext
There was a problem hiding this comment.
@queengooborg FYI, given the time it was taking to crosscheck these changes with the referenced PR, my review has been largely limited to confirming that the updated version number is consistent with the PR dates.
| @@ -3793,7 +3772,7 @@ | |||
| "mdn_url": "https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/tabs/sendMessage", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": true | |||
| "version_added": "≤41" | |||
There was a problem hiding this comment.
@queengooborg typo? Should this also be 61
There was a problem hiding this comment.
sendMessage.options.frameId is marked as implemented in 41, so the sendMessage feature had to have been implemented in at least Chrome 41!
| @@ -3961,7 +3934,7 @@ | |||
| "mdn_url": "https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/tabs/update", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": true | |||
| "version_added": "≤18" | |||
There was a problem hiding this comment.
@queengooborg where did this come from? Doesn't seem to be covered in the referenced PR.
There was a problem hiding this comment.
This is to maintain consistency with the updateProperties_openerTabId_parameter subfeature!
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the
tabsWeb Extensions interface. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacingtruevalues with ranged values to eliminatetruevalues from BCD.Commit/PR Adding the Feature: #512, #469, #446