Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromium data for menus Web Extensions interface #24277

Merged

Conversation

queengooborg
Copy link
Contributor

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the menus Web Extensions interface. The data comes from a commit in the browser's source code, mapped to a version number using available tooling or via the commit timestamp.

Commit: https://source.chromium.org/chromium/chromium/src/+/34b3680e16699f573c9ecedb580837d1638b8259, https://source.chromium.org/chromium/chromium/src/+/69e1c12d5b212fc29af5f31982ccca8cb66e5c01, https://chromiumdash.appspot.com/commit/3232d3f93d80e62098515c300ac17bfd27d047f3, https://source.chromium.org/chromium/chromium/src/+/00f1fc22bfcc653b47d62778170af3eee9855720, https://source.chromium.org/chromium/chromium/src/+/aefa99e2b6abcb3e1b347d10d2b9a0e4110c68f7

@queengooborg queengooborg added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Sep 3, 2024
@queengooborg queengooborg added the KR: Real BCD Key Result: Eliminate true/null values and replace them with "real" values. label Sep 3, 2024
@queengooborg queengooborg requested a review from caugner November 19, 2024 03:33
@github-actions github-actions bot added the size:s [PR only] 7-24 LoC changed label Nov 20, 2024
webextensions/api/menus.json Outdated Show resolved Hide resolved
webextensions/api/menus.json Outdated Show resolved Hide resolved
webextensions/api/menus.json Show resolved Hide resolved
webextensions/api/menus.json Outdated Show resolved Hide resolved
webextensions/api/menus.json Show resolved Hide resolved
webextensions/api/menus.json Outdated Show resolved Hide resolved
webextensions/api/menus.json Outdated Show resolved Hide resolved
webextensions/api/menus.json Outdated Show resolved Hide resolved
webextensions/api/menus.json Show resolved Hide resolved
@caugner
Copy link
Contributor

caugner commented Nov 22, 2024

Compact diff grouped by value:
image

@caugner
Copy link
Contributor

caugner commented Nov 22, 2024

@queengooborg Looking at that diff, I feel like the altname shouldn't be duplicated on the members? (But this is a separate issue.)

@caugner caugner merged commit 8c8c292 into mdn:main Nov 22, 2024
7 checks passed
@queengooborg queengooborg deleted the webextensions/api/menus/chrome-corrections branch November 22, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions KR: Real BCD Key Result: Eliminate true/null values and replace them with "real" values. size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants