-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromium 131 validates depth bias on line and point topologies #24811
Chromium 131 validates depth bias on line and point topologies #24811
Conversation
@chrisdavidmills Are you aware of other spec changes that were documented in BCD in a similar fashion? My two thoughts are:
PS: It looks like Chrome 131 removes the warning in favor of an error. |
Ah right, so it looks like this should be Chrome 131 rather than 128 then. So, we document But, if it is deemed to be too detailed, we could not include it as a separate data point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo question
"status": { | ||
"experimental": true, | ||
"standard_track": true, | ||
"deprecated": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the deprecated field used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a feature has been officially deprecated, then we set "deprecated"
to true
. I know you used "deprecated" to describe what has happened, but when I looked at it, it seemed like a change in behavior rather than a true deprecation. Does that work, or do you think I should reconsider how I've described this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec said A, then they changed it to B.
We announced deprecation in Chrome 128 and removed it in Chrome 131.
I'll let you pick what is more appropriate in BCD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 131 makes more sense — when it starts to produce an error rather than the warning. I've updated it.
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Summary
Chrome 128 deprecates setting depth bias for lines and points (Chrome issue, spec change).
This PR adds a datapoint for this change in behavior to
GPUDevice.createRenderPipeline()
andGPUDevice.createRenderPipelineAsync()
.Test results and supporting details
See the description and data source
Related issues
See related MDN project issue: mdn/content#36341