Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename HTMLButtonElement.{command => commandForElement} + duplicate to button.{command,commandfor} #24917

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Rename HTMLButtonElement.{command => commandForElement} + duplicate to button.{command,commandfor} #24917

merged 1 commit into from
Nov 4, 2024

Conversation

Josh-Cena
Copy link
Member

commandfor is an HTML attribute and should not be in API data. Added the right data

@github-actions github-actions bot added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Nov 3, 2024
@Playaset Playaset mentioned this pull request Nov 3, 2024
Closed
caugner
caugner approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified that the copied features have the same values as the original.

@caugner caugner changed the title fix HTMLButtonElement.commandForElement, add content attribute data Rename HTMLButtonElement.{command => commandForElement} + duplicate to html.elements.button.{command,commandfor} Nov 4, 2024
@caugner caugner changed the title Rename HTMLButtonElement.{command => commandForElement} + duplicate to html.elements.button.{command,commandfor} Rename HTMLButtonElement.{command => commandForElement} + duplicate to button.{command,commandfor} Nov 4, 2024
@caugner caugner merged commit 821a1ac into mdn:main Nov 4, 2024
5 checks passed
@mdn-bot mdn-bot mentioned this pull request Nov 4, 2024
Merged
@Josh-Cena Josh-Cena deleted the invokers branch November 4, 2024 13:47
@mdn-bot mdn-bot mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @caugner