docs(contributing): update WebView Android interface exposure link #26387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
Elchi3
reviewed
Apr 7, 2025
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Hm, sad. Could this be an alternative: https://source.chromium.org/chromium/chromium/src/+/main:android_webview/test/data/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt ?
cc @foolip
Contributor
Author
Looks promising, but I'd link to https://github.com/chromium/chromium/blob/main/android_webview/test/data/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt instead, because it's easier to blame / see history. |
caugner
commented
Apr 15, 2025
caugner
commented
Apr 15, 2025
caugner
commented
Apr 15, 2025
Co-authored-by: Florian Scholz <fs@florianscholz.com>
caugner
force-pushed
the
remove-obsolete-chromium-link
branch
from
8ffb924 to
a3922ec
Compare
caugner
changed the title
caugner
changed the title
Elchi3
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the link to the
not-webview-exposed.txtfile in the Chromium repo, which was deleted in https://source.chromium.org/chromium/chromium/src/+/d83e960b676d9b7761163445d6e514f70dcf2719.Instead, adds a link to the
android_webview/…/global-interface-listing-expected.txtfile, which lists exposed interfaces (rather than not exposed features).Test results and supporting details
Related issues