-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Restructure ranged style query data #28537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ddbeck, this looks reasonable to me. I did wonder whether all the query types should have a data point in both files for consistency, so:
- container.json should have a "size queries" data point at the same level as
scroll-state_queriesandstyle_queries_for_custom_properties? - if.json should have "size" and "scroll state" data points at the same level as
style?
The main data point in each case kinda covers these, but it feels a little weird given that the support data for some of the existing sub-data is the same as for the main data point.
I kinda expect named things to have keys, but size queries are anonymous. If I were creating this data from scratch today, I'd probably have structured it like this:
Honestly, I'm not quite sure how
Yeah, this happens often in CSS (e.g., you have some "basic" value for a property having the same support information as the parent property key), but does appear elsewhere (e.g., there's a key for the |
Duh, I'm being stupid here.
Yeah, that makes sense.I think we are good to go. |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ddbeck.
Summary
Restructure the ranged style query data newly added by #28510.
Test results and supporting details
There's no new information here, but I've restructured the data to be less surprisingly flat. When I was authoring web-platform-dx/web-features#3579, I predicted some keys that did not yet exist in BCD, but what I found was rather different and confusing. In particular, the ranged behavior is a peer to style queries, not a subfeature.
Here's the before:
And here's my after (new in bold, removed in
strike):css.at-rules.container.style_queries_range_syntaxcss.types.if.style_queries_range_syntaxThis implies that we'd add some other keys at some point, namely:
Related issues
A follow up to: