Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Edge 13 data based on Confluence #3309

Closed
wants to merge 1 commit into from

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Jan 18, 2019

Produced by npm run confluence -- --fill-only --browsers=edge with
local changes applied to only include changes where the new version
was 13. Since Edge 12 was the first version of Edge and we don't have
data for Edge 12, this means we can't know if these APIs were first in
Edge 12 or Edge 13, so it can only say true.

@foolip
Copy link
Contributor Author

foolip commented Jan 18, 2019

@Elchi3 can you review?

@foolip
Copy link
Contributor Author

foolip commented Jan 18, 2019

@patrickkettner this is the PR I asked about. In https://en.wikipedia.org/wiki/Microsoft_Edge#Release_history it appears that there was a stable release of Edge 12, there is a fair bit of "version_added": "12" in the data currently. Given this, if we have data from Edge 13 but not Edge 12, is it best to use 13 or true to represent this?

If there's some way to get hold of an Edge 12 build that would be cool of course.

@foolip
Copy link
Contributor Author

foolip commented Jan 18, 2019

I did a bit of looking around for old versions of Windows 10, and based on https://answers.microsoft.com/en-us/windows/forum/windows_10-windows_install/how-to-get-an-older-windows-10-iso-eg-build-1511/ff09c5af-0932-4459-8048-17f638d6f87f it seems unlikely one can get hold of Edge 12 still.

@foolip foolip changed the title Add missing Edge data based on Confluence Add missing Edge 13 data based on Confluence Jan 18, 2019
Produced by `npm run confluence -- --fill-only --browsers=edge` with
local changes applied to only include changes where the new version
was 13. Since Edge 12 was the first version of Edge and we don't have
data for Edge 12, this means we can't know if these APIs were first in
Edge 12 or Edge 13, so it can only say true.
@foolip foolip force-pushed the confluence-edge-true branch from 0aed42e to f2720fe Compare January 18, 2019 19:24
@saschanaz
Copy link
Contributor

IMO too many new trues here, we could do <=13 or something if we had a solution for #3021.

@saschanaz
Copy link
Contributor

@foolip Microsoft still somehow serves the old build 10240, here's how to get it: https://www.intowindows.com/download-windows-10-rtm-esd-iso-from-microsoft-now/

@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 21, 2019
@foolip
Copy link
Contributor Author

foolip commented Jan 21, 2019

I'd be happy to do <=13 if that were possible. I'll see if I can get that image working though.

@foolip
Copy link
Contributor Author

foolip commented Jan 31, 2019

I've been able to collect data from Edge 12 in mdittmer/web-apis#75. I'll close this PR and open another that takes that data into account.

@foolip foolip closed this Jan 31, 2019
@foolip foolip deleted the confluence-edge-true branch January 31, 2019 10:47
@Elchi3
Copy link
Member

Elchi3 commented Jan 31, 2019

Thanks so much @foolip! 🎉

@Elchi3 Elchi3 added invalid Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry! and removed data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API labels Jan 31, 2019
@foolip
Copy link
Contributor Author

foolip commented Feb 5, 2019

Edge 12 data in #3392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Invalid issues or pull requests (wrong repo, spam, duplicates, etc.). This won't get merged. Sorry!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants