Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version inconsistencies in http/* #3378

Merged

Conversation

queengooborg
Copy link
Contributor

Sub-PR of #3368 for the fixes of the files themselves.

@Elchi3 Elchi3 added the data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label Feb 5, 2019
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve the changes to Content-Security-Policy and Public-Key-Pins. Nice detection and the corrections look good to me!

For Feature-Policy I would like @jpmedley's input. The data looks odd indeed. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy#Browser_compatibility where you have version 60 for the basic support of the header but then e.g. 59 for camera which makes no sense, because you need the header to use the camera directive of this header... I wonder if Joe has more information that explains these and other inconsistencies for Feature-Policy.

http/headers/feature-policy.json Show resolved Hide resolved
http/headers/feature-policy.json Show resolved Hide resolved
@jpmedley
Copy link
Contributor

jpmedley commented Feb 6, 2019

I would need to do some digging. At a gut level, I'd have to say the original values are correct. I submitted the original data while I was working directly with the guys who designed and built feature policy.

@Elchi3
Copy link
Member

Elchi3 commented Feb 6, 2019

Thanks Joe, I appreciate that as they make no apparent sense right now. Maybe they will with additional explanation.

@jpmedley
Copy link
Contributor

jpmedley commented Feb 6, 2019

It looks like my collaborators weren't looking closely enough at my PRs. Anything earlier than 60 should be set to 60.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vinyldarkscratch for the PR and @jpmedley for getting answers here 🎉

@Elchi3 Elchi3 merged commit 1b59318 into mdn:master Feb 6, 2019
@queengooborg queengooborg deleted the linter/lint-version-consistency-apply/http branch February 7, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants