-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version inconsistencies in http/* #3378
Fix version inconsistencies in http/* #3378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can approve the changes to Content-Security-Policy and Public-Key-Pins. Nice detection and the corrections look good to me!
For Feature-Policy I would like @jpmedley's input. The data looks odd indeed. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Feature-Policy#Browser_compatibility where you have version 60 for the basic support of the header but then e.g. 59 for camera which makes no sense, because you need the header to use the camera directive of this header... I wonder if Joe has more information that explains these and other inconsistencies for Feature-Policy.
I would need to do some digging. At a gut level, I'd have to say the original values are correct. I submitted the original data while I was working directly with the guys who designed and built feature policy. |
Thanks Joe, I appreciate that as they make no apparent sense right now. Maybe they will with additional explanation. |
It looks like my collaborators weren't looking closely enough at my PRs. Anything earlier than 60 should be set to 60. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vinyldarkscratch for the PR and @jpmedley for getting answers here 🎉
Sub-PR of #3368 for the fixes of the files themselves.