Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version inconsistencies in javascript/* #3379

Merged
merged 5 commits into from
Feb 11, 2019
Merged

Fix version inconsistencies in javascript/* #3379

merged 5 commits into from
Feb 11, 2019

Conversation

queengooborg
Copy link
Contributor

Sub-PR of #3368 for the fixes of the files themselves.

@queengooborg queengooborg mentioned this pull request Feb 4, 2019
Merged
@Elchi3 Elchi3 added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Feb 5, 2019
Elchi3
Elchi3 requested changes Feb 7, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, many good findings here! Some false positives also apparently. Please see my inline comments.

javascript/builtins/Atomics.json Outdated Show resolved Hide resolved
javascript/builtins/Intl.json Show resolved Hide resolved
javascript/builtins/Intl.json Show resolved Hide resolved
javascript/builtins/Intl.json Outdated Show resolved Hide resolved
javascript/builtins/Intl.json Outdated Show resolved Hide resolved
javascript/builtins/Intl.json Outdated Show resolved Hide resolved
javascript/builtins/Intl.json Outdated Show resolved Hide resolved
javascript/builtins/Intl.json Outdated Show resolved Hide resolved
javascript/builtins/Intl.json Outdated Show resolved Hide resolved
javascript/statements.json Outdated Show resolved Hide resolved
@queengooborg
Copy link
Contributor Author

Seems that javascript/builtins/Intl.json has some inconsistencies to resolve that a simple script won't do. I'm not an Android user so I can't really dig into it much!

@Elchi3
Copy link
Member

Elchi3 commented Feb 8, 2019

Thanks!
I think for the two changes from null to false it isn't actually an inconsistency? If so we could leave it with null.
For the changes from 63 to false, I think 63 is correct. Can you point to what's inconsistent there?

@queengooborg
Copy link
Contributor Author

You're right, neither the null -> false nor 63 -> false changes were correct in this scenario, that was my bad. Fixed them now!

Elchi3
Elchi3 approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit 6e44211 into mdn:master Feb 11, 2019
@queengooborg queengooborg deleted the linter/lint-version-consistency-apply/javascript branch February 11, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Elchi3