Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Edge 18 data based on Confluence #3475

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Feb 18, 2019

Produced by npm run confluence -- --fill-only --browsers=edge with
local changes applied to only include changes where the new version
was 18.

To review this, double check each change manually by running some scripts in Edge 17 and Edge 18. (I will self-review first.)

Produced by `npm run confluence -- --fill-only --browsers=edge` with
local changes applied to only include changes where the new version
was 18.
Copy link
Contributor Author

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed up to api/HTMLMeterElement.json without finding any errors yet. I'd like to check the rest though, so not ready to merge.

api/Document.json Show resolved Hide resolved
api/FormData.json Show resolved Hide resolved
api/HTMLAnchorElement.json Show resolved Hide resolved
api/HTMLAreaElement.json Show resolved Hide resolved
api/HTMLButtonElement.json Show resolved Hide resolved
api/HTMLInputElement.json Show resolved Hide resolved
api/HTMLLabelElement.json Show resolved Hide resolved
api/HTMLMeterElement.json Show resolved Hide resolved
@Elchi3 Elchi3 added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript labels Feb 18, 2019
api/HTMLObjectElement.json Show resolved Hide resolved
api/HTMLOutputElement.json Show resolved Hide resolved
api/HTMLProgressElement.json Show resolved Hide resolved
api/HTMLSelectElement.json Show resolved Hide resolved
api/HTMLTextAreaElement.json Show resolved Hide resolved
api/RadioNodeList.json Show resolved Hide resolved
api/SourceBuffer.json Show resolved Hide resolved
api/Worker.json Show resolved Hide resolved
javascript/builtins/Intl.json Show resolved Hide resolved
api/XMLHttpRequestEventTarget.json Outdated Show resolved Hide resolved
@foolip
Copy link
Contributor Author

foolip commented Feb 19, 2019

@Elchi3 I've reviewed 100% of these changes and reverted the only questionable case. Ready to merge I think.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @foolip 👍 I've double-checked a few (3-4) in Saucelabs and searched if second handed info (like caniuse) confirms some (2-3) of these. It looks all good to me.

@Elchi3 Elchi3 merged commit f49d775 into mdn:master Feb 19, 2019
@foolip foolip deleted the confluence-edge-18 branch February 19, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants