-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Edge 18 data based on Confluence #3475
Conversation
Produced by `npm run confluence -- --fill-only --browsers=edge` with local changes applied to only include changes where the new version was 18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed up to api/HTMLMeterElement.json without finding any errors yet. I'd like to check the rest though, so not ready to merge.
@Elchi3 I've reviewed 100% of these changes and reverted the only questionable case. Ready to merge I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @foolip 👍 I've double-checked a few (3-4) in Saucelabs and searched if second handed info (like caniuse) confirms some (2-3) of these. It looks all good to me.
Produced by
npm run confluence -- --fill-only --browsers=edge
withlocal changes applied to only include changes where the new version
was 18.
To review this, double check each change manually by running some scripts in Edge 17 and Edge 18. (I will self-review first.)