Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Opera versions #3874

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Update Opera versions #3874

merged 3 commits into from
Apr 18, 2019

Conversation

queengooborg
Copy link
Contributor

This PR updates Opera releases to match latest updates. Based upon https://help.opera.com/en/opera-version-history/, it looks like version 59 never left beta before they released version 60, codenamed "Reborn 3". Thus, no release notes or release date was actually made for Opera 59.

@queengooborg queengooborg added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Apr 13, 2019
@queengooborg queengooborg requested a review from Elchi3 April 13, 2019 06:15
@Elchi3
Copy link
Member

Elchi3 commented Apr 15, 2019

So, version 59 does not really exist then? Sigh. I guess it would be easier to still have it listed here?

Technically, the features in "59" (Chromium 72) are only available to end-users in version 60 along with everything from Chromium 73 then, I guess.

Edit: Another situation where I wish the vendor would comment and help us to communicate their versions in their preferred way.

@queengooborg
Copy link
Contributor Author

queengooborg commented Apr 15, 2019

That’s what it seems like to me. Unlike Opera Android though, I’m glad they continued with the version numbers as normal, rather than confuse us! Since Opera 59 still had a beta release, I feel that we should leave it in our data.

@Elchi3
Copy link
Member

Elchi3 commented Apr 18, 2019

Since Opera 59 still had a beta release, I feel that we should leave it in our data.

Well, I think, for other browsers, we didn't add non-releases like beta versions. In the Firefox Android data, for example, we've left out beta versions. How much is Opera 59 already populated in the data set?

@queengooborg
Copy link
Contributor Author

Ah, makes sense. It looks like there was only four instances across three files that referenced Opera 59:

api/FetchEvent.json
http/headers/feature-policy.json - 2 times
javascript/builtins/JSON.json

@Elchi3
Copy link
Member

Elchi3 commented Apr 18, 2019

Then, I think, we should remove 59 and mark those as shipped in Opera 60 instead.

@queengooborg
Copy link
Contributor Author

Works for me!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have no contact to Opera to ask for opinions, thus going ahead with this PR, as it seems most consistent to what we've done for other browsers.

@Elchi3 Elchi3 merged commit 667263c into mdn:master Apr 18, 2019
@queengooborg queengooborg deleted the browsers/opera branch April 18, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants