First part of the BCD for the Web Audio API #433

chrisdavidmills · 2017-09-29T11:02:15Z

No description provided.

teoli2003

Overall really good, beside a few specific things, most comments are generic (how we do constructors, interface-level info, how we do alternate names, where we indicate prefixing, ordering of browsers).

teoli2003 · 2017-10-02T17:33:55Z

api/AnalyserNode.json

+      "AnalyserNode": {
+        "__compat": {
+          "mdn_url": "https://developer.mozilla.org/docs/Web/API/AnalyserNode/AnalyserNode",
+          "support": {


Can you put the support content in this order:
"webview_android"
"chrome"
"chrome_firefox"
"edge"
"edge_mobile"
"firefox"
"firefox_android"
"ie"
"ie_mobile"
"opera"
"opera_android"
"safari"
"safari_ios"

It makes it much easier to review (similar values are kept together), is closer to alphabetical order (except webview), and is easier to update values (desktop and mobile often change at the same time).

teoli2003 · 2017-10-02T17:34:30Z

api/AnalyserNode.json

+              {
+                "version_added": "14",
+                "version_removed": "34",
+                "prefix": "-webkit-"


The prefix is "webkit" leading to webkitfftSize and not to -webkit-fftSize.

teoli2003 · 2017-10-02T17:35:11Z

api/AnalyserNode.json

+              },
+              {
+                "version_added": "14",
+                "version_removed": "34",


Is the prefix no more supported ("34") or supported in parallel (no "version_removed" entry)?

teoli2003 · 2017-10-02T17:35:31Z

api/AnalyserNode.json

+              {
+                "version_added": "15",
+                "version_removed": "21",
+                "prefix": "-webkit-"


The prefix is "webkit".

teoli2003 · 2017-10-02T17:35:39Z

api/AnalyserNode.json

+              },
+              {
+                "version_added": "15",
+                "version_removed": "21",


"21" or no version_removed?

teoli2003 · 2017-10-04T10:44:32Z

api/AudioListener.json

+            },
+            "firefox_android": {
+              "version_added": false,
+              "notes": "Still supports the older way of setting orientation — the <code>setOrientation()</code> method."


teoli2003 · 2017-10-04T10:44:38Z

api/AudioListener.json

+            },
+            "firefox": {
+              "version_added": false,
+              "notes": "Still supports the older way of setting orientation — the <code>setOrientation()</code> method."


teoli2003 · 2017-10-04T10:44:43Z

api/AudioListener.json

+            },
+            "firefox_android": {
+              "version_added": false,
+              "notes": "Still supports the older way of setting orientation — the <code>setOrientation()</code> method."


teoli2003 · 2017-10-04T10:47:34Z

api/AudioScheduledSourceNode.json

+              {
+                "version_added": "25",
+                "version_removed": "52",
+                "notes": "Interface implemented as AudioSourceNode."


This should be on the interface compat status, and using the "alternate_name" methodology

teoli2003 · 2017-10-04T10:47:59Z

api/AudioScheduledSourceNode.json

+              {
+                "version_added": "22",
+                "version_removed": "43",
+                "notes": "Interface implemented as AudioSourceNode."


Ditto (I'm not repeating this)

… interface level compat data

chrisdavidmills · 2017-10-04T16:19:41Z

OK, I'm not finished yet, but I have done most of the work. Most of the stuff left to do is around the webkit vendor prefixes.

Thinking back on it, I think I might have got this all totally wrong, when I wrote all these compat tables way back when I originally documented the WAA.

I reckon the only parts of the WAA that were prefixed when Chrome first implemented it were AudioContext and OfflineAudioContext, These were the only entry point to the API back then — you'd create any other node types with audioCtx.createGain or whatever (these days such nodes have constructors, but you still probably wouldn't use them).

So I reckon I can get rid of most of this stuff. I've had a good look on the internet, and I can't find any reference to other prefixed WAA interfaces, or methods and properties.

I am however surprised that noone would ever have pointed out such errors in our support data over all these years.

what do you think?

teoli2003 · 2017-10-04T17:25:27Z

I think you are right, only the initial access point needed a prefix if I recall correctly.
(And you have a travis failure, likely a typo)

chrisdavidmills · 2017-10-04T17:46:58Z

OK, time to nuke some prefix information then ;-)

teoli2003

Yes, we are getting closer! This time we are dealing with the meat of this review :-)

teoli2003 · 2017-10-05T10:47:40Z

api/AudioBufferSourceNode.json

+          "description": "<code>AudioBufferSourceNode()</code> constructor",
+          "support": {
+            "webview_android": {
+              "version_added": "55"


Missing note: "Before version 59, the default values were not supported."

teoli2003 · 2017-10-05T10:47:46Z

api/AudioBufferSourceNode.json

+              "version_added": "55"
+            },
+            "chrome": {
+              "version_added": "55"


Missing note: "Before version 59, the default values were not supported."

teoli2003 · 2017-10-05T10:47:53Z

api/AudioBufferSourceNode.json

+              "version_added": "55"
+            },
+            "chrome_android": {
+              "version_added": "55"


Missing note: "Before version 59, the default values were not supported."

teoli2003 · 2017-10-05T11:14:18Z

api/AudioBufferSourceNode.json

+              "version_added": true
+            },
+            "firefox": {
+              "version_added": "25"


Is comment [2] at https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/buffer still applicable. (If so add it, if not, forget it, or indicate when it was fixed)

teoli2003 · 2017-10-05T11:14:25Z

api/AudioBufferSourceNode.json

+              "version_added": "25"
+            },
+            "firefox_android": {
+              "version_added": "26"


teoli2003 · 2017-10-05T14:48:16Z

api/AudioScheduledSourceNode.json

+            {
+              "version_added": "14",
+              "version_removed": "56",
+              "notes": "Interface implemented as AudioSourceNode."


teoli2003 · 2017-10-05T14:48:22Z

api/AudioScheduledSourceNode.json

+            {
+              "version_added": "25",
+              "version_removed": "52",
+              "notes": "Interface implemented as AudioSourceNode."


teoli2003 · 2017-10-05T14:48:27Z

api/AudioScheduledSourceNode.json

+            {
+              "version_added": "25",
+              "version_removed": "52",
+              "notes": "Interface implemented as AudioSourceNode."


teoli2003 · 2017-10-05T14:48:34Z

api/AudioScheduledSourceNode.json

+            {
+              "version_added": "15",
+              "version_removed": "43",
+              "notes": "Interface implemented as AudioSourceNode."


teoli2003 · 2017-10-05T14:48:39Z

api/AudioScheduledSourceNode.json

+            {
+              "version_added": "15",
+              "version_removed": "43",
+              "notes": "Interface implemented as AudioSourceNode."


teoli2003

2 small changes are still to be done (7 times for the second one, but they are extremely tiny.

With these fixed, LGTM, r+

teoli2003 · 2017-10-06T05:53:32Z

api/AudioContext.json

+        },
+        "options": {
+          "__compat": {
+            "description": "Support for the <code>options</code> parameter.",


Drop the "Support for the"; we are describing the compat, so for each subfeature we list if it is supported or not, it is redundant. Just plain "options parameter" (no dot either, it isn't a note).

teoli2003 · 2017-10-06T05:55:26Z

api/AudioScheduledSourceNode.json

@@ -11,7 +11,7 @@
            {
              "version_added": "14",
              "version_removed": "56",
-              "notes": "Interface implemented as AudioSourceNode."
+              "alternative_name": "Interface implemented as AudioSourceNode."


Alternative_name is not a sentence; currently it doesn't even appear as a note in the generated table on mdn, but this name is used to build as structure like: 14-56 as AudioSourceNode.

So "alternative_name": "AudioSourceNode".

teoli2003 · 2017-10-06T05:55:30Z

api/AudioScheduledSourceNode.json

@@ -21,7 +21,7 @@
            {
              "version_added": "14",
              "version_removed": "56",
-              "notes": "Interface implemented as AudioSourceNode."
+              "alternative_name": "Interface implemented as AudioSourceNode."


"alternative_name": "AudioSourceNode".

teoli2003 · 2017-10-06T05:55:37Z

api/AudioScheduledSourceNode.json

@@ -31,7 +31,7 @@
            {
              "version_added": "14",
              "version_removed": "56",
-              "notes": "Interface implemented as AudioSourceNode."
+              "alternative_name": "Interface implemented as AudioSourceNode."


"alternative_name": "AudioSourceNode".

teoli2003 · 2017-10-06T05:55:45Z

api/AudioScheduledSourceNode.json

@@ -47,7 +47,7 @@
            {
              "version_added": "25",
              "version_removed": "52",
-              "notes": "Interface implemented as AudioSourceNode."
+              "alternative_name": "Interface implemented as AudioSourceNode."


"alternative_name": "AudioSourceNode".

teoli2003 · 2017-10-06T05:55:51Z

api/AudioScheduledSourceNode.json

@@ -57,7 +57,7 @@
            {
              "version_added": "25",
              "version_removed": "52",
-              "notes": "Interface implemented as AudioSourceNode."
+              "alternative_name": "Interface implemented as AudioSourceNode."


"alternative_name": "AudioSourceNode".

teoli2003 · 2017-10-06T05:55:57Z

api/AudioScheduledSourceNode.json

@@ -73,7 +73,7 @@
            {
              "version_added": "15",
              "version_removed": "43",
-              "notes": "Interface implemented as AudioSourceNode."
+              "alternative_name": "Interface implemented as AudioSourceNode."


"alternative_name": "AudioSourceNode".

teoli2003 · 2017-10-06T05:56:06Z

api/AudioScheduledSourceNode.json

@@ -83,7 +83,7 @@
            {
              "version_added": "15",
              "version_removed": "43",
-              "notes": "Interface implemented as AudioSourceNode."
+              "alternative_name": "Interface implemented as AudioSourceNode."


"alternative_name": "AudioSourceNode".

teoli2003

\o/

Elchi3 · 2017-10-06T08:00:27Z

wooohooo \o/

These notes have been in BCD since the very beginning: mdn#433 Chrome 55 is the right version for the constructors overall: https://storage.googleapis.com/chromium-find-releases-static/579.html#57909df69be0cf0b2ac42e5c9c018d4a00ee9766 The Chrome 59 change is this one: https://storage.googleapis.com/chromium-find-releases-static/ef0.html#ef006156fd62853a893617ca104f4ac2045e19c1 Adding default values to dictionary members is by itself not necessarily a web observable changes at all. This was confirmed with one case comparing Chrome 58 and 59: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10708 One part of this was observable, with the OscillatorNode constructor: https://bugs.chromium.org/p/chromium/issues/detail?id=710471 This was a spec bug, and fixed in the spec around the same time: WebAudio/web-audio-api#1173 Overall, this change does not seem noteworthy enough to record in BCD.

These notes have been in BCD since the very beginning: #433 Chrome 55 is the right version for the constructors overall: https://storage.googleapis.com/chromium-find-releases-static/579.html#57909df69be0cf0b2ac42e5c9c018d4a00ee9766 The Chrome 59 change is this one: https://storage.googleapis.com/chromium-find-releases-static/ef0.html#ef006156fd62853a893617ca104f4ac2045e19c1 Adding default values to dictionary members is by itself not necessarily a web observable changes at all. This was confirmed with one case comparing Chrome 58 and 59: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10708 One part of this was observable, with the OscillatorNode constructor: https://bugs.chromium.org/p/chromium/issues/detail?id=710471 This was a spec bug, and fixed in the spec around the same time: WebAudio/web-audio-api#1173 Overall, this change does not seem noteworthy enough to record in BCD.

first part of the BCD for the Web Audio API

63bf02a

Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 29, 2017

teoli2003 suggested changes Oct 4, 2017

View reviewed changes

fixing order of browsers, adding constructor descriptions, and adding…

82bb722

… interface level compat data

chrisdavidmills added 3 commits October 4, 2017 19:20

removing erroneous prefix details

5936421

Fixing Jean-Yves last few comments

b1bf23d

Fixing indentation error

386e1be

teoli2003 suggested changes Oct 5, 2017

View reviewed changes

fixing the last few update requests

0f5cf8d

teoli2003 suggested changes Oct 6, 2017

View reviewed changes

last couple of teensy bits

374c715

teoli2003 approved these changes Oct 6, 2017

View reviewed changes

teoli2003 merged commit 18199e0 into mdn:master Oct 6, 2017

chrisdavidmills deleted the web-audio-api branch January 19, 2018 09:59

snyk-bot mentioned this pull request Dec 20, 2021

[Snyk] Upgrade browser-specs from 2.7.0 to 2.16.1 hixio-mh/browser-compat-data#56

Open

foolip mentioned this pull request Sep 15, 2022

Remove "default values" notes for Web Audio constructors #17811

Merged

queengooborg mentioned this pull request Nov 25, 2022

Update Chromium versions for Audio APIs #18301

Merged

First part of the BCD for the Web Audio API #433

First part of the BCD for the Web Audio API #433

Conversation

chrisdavidmills commented Sep 29, 2017

teoli2003 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisdavidmills commented Oct 4, 2017

teoli2003 commented Oct 4, 2017 • edited Loading

chrisdavidmills commented Oct 4, 2017

teoli2003 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teoli2003 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teoli2003 left a comment

Choose a reason for hiding this comment

Elchi3 commented Oct 6, 2017

teoli2003 commented Oct 4, 2017 •

edited

Loading