Corrections to Blob. #4597
Merged
Corrections to Blob. #4597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/Blob.json
Outdated
| @@ -209,7 +209,7 @@ | |||
| } | |||
| ], | |||
| "chrome_android": { | |||
| "version_added": true | |||
| "version_added": "25" | |||
There was a problem hiding this comment.
This all looks great, just have one little question. Chrome Desktop had the webkit prefix from version 5 to version 25. Technically, wouldn't that mean Chrome Android 18 would have the webkit prefix as well?
There was a problem hiding this comment.
Fixed. Please look again.
There was a problem hiding this comment.
Thanks for clarification!
queengooborg
added
the
data:api 🐇
queengooborg
requested changes
Aug 12, 2019
api/Blob.json
Outdated
| "version_added": "25" | ||
| }, | ||
| { | ||
| "version_added": "5", |
There was a problem hiding this comment.
Whoops, looks like this got set as “5” when it should be “18”, correct?
There was a problem hiding this comment.
All good, thanks for the quick fixes! This pull request looks all ready to go!
queengooborg
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions to #4581