Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Edge Math compat data #4774

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Update Edge Math compat data #4774

merged 1 commit into from
Sep 6, 2019

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Sep 5, 2019

This is a test PR to measure how long it takes to update a chunk of Edge JS compat data. It updates 14 data points and I've spend maybe 15 minutes on it. Please let me know how long you spend reviewing.

Math functions that are ancient (and already supported in IE) are definitely also in Edge 12.
For newer Math functions, I found https://developer.microsoft.com/en-us/microsoft-edge/platform/status/mathbuiltinses6 which makes those version 12 as well.

@Elchi3 Elchi3 added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Sep 5, 2019
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! It took about twenty minutes for me to review this -- just a little review of Windows build numbers and that was pretty much all. 😛

Let's get this merged!

@queengooborg queengooborg merged commit c978332 into master Sep 6, 2019
@Elchi3 Elchi3 deleted the js-edge-math branch September 6, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants