Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IE/Edge versions for JavaScript functions properties #4787

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Sep 7, 2019

This PR sets the Internet Explorer and Edge versions for the missing JavaScript Functions properties, both through manual testing (SauceLabs and VMs) and through reading developer documentation.

javascript.builtins.Function.apply - true 5.5
javascript.builtins.Function.apply.generic_arrays_as_arguments - true 9
javascript.builtins.Function.length.configurable_true - true 12
javascript.builtins.Function.name.configurable_true - true 12
javascript.builtins.Function.name.inferred_names - partial 12 Names for functions defined in a dictionary are properly assigned; however, anonymous functions defined on a var/let variable assignment have blank names.
javascript.builtins.GeneratorFunction - true 13 - https://developer.microsoft.com/en-us/microsoft-edge/platform/status/generatorses6
javascript.builtins.GeneratorFunction.prototype - true 13 - https://developer.microsoft.com/en-us/microsoft-edge/platform/status/generatorses6

@queengooborg queengooborg added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Sep 7, 2019
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you! 👍

@Elchi3 Elchi3 merged commit 5dcf7b9 into mdn:master Sep 9, 2019
@queengooborg queengooborg deleted the javascript/ie-edge-functions branch September 9, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants