Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove iOS 11.1 from data #4835

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Remove iOS 11.1 from data #4835

merged 3 commits into from
Oct 14, 2019

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Sep 18, 2019 •
edited
Loading

To help reduce some confusion, this PR removes Safari iOS 11.1 as an option. Safari 11.1 was introduced in iOS 11.3, yet our compatibility data contains iOS 11.1, which seems to present confusion about whether to use the Safari or iOS versions.

Depends on #4834.

@ghost ghost added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript labels Sep 18, 2019
@queengooborg queengooborg added bulk_update An update to a mass amount of data, or scripts/linters related to such changes not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. and removed data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript labels Sep 18, 2019
@ghost ghost added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript labels Sep 21, 2019
@queengooborg queengooborg removed data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels Sep 21, 2019
@queengooborg queengooborg changed the title Remove Safari iOS 11.1 (Safari 11.1 = iOS 11.3) Remove iOS 11.1 from data Sep 22, 2019
@queengooborg queengooborg mentioned this pull request Sep 22, 2019
Closed
Elchi3
Elchi3 requested changes Oct 14, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One (somewhat related) thing to fix here, but looks good to me otherwise. Thank you!

html/elements/iframe.json Outdated Show resolved Hide resolved
@ghost ghost added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript labels Oct 14, 2019
Elchi3
Elchi3 approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit 795f045 into mdn:master Oct 14, 2019
@queengooborg queengooborg deleted the browsers/safari-ios/11.1 branch October 14, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
bulk_update An update to a mass amount of data, or scripts/linters related to such changes data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Elchi3