-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api.TextMetrics compatibility for Chrome and Edge #5659
Conversation
I wonder if instead of removing flag data, I should make them arrays of objects, as such: [
{
"version_added": "77"
},
{
"version_added": true,
"version_removed": "77",
"flags": [
{
"type": "preference",
"name": "Experimental Web Platform Features"
}
]
}
] |
Is anyone here? I see other PRs being created and merged and mine just getting ignored for a week 🤔 |
Hey, sorry for the slow response, but as you've seen there are a lot of PRs here, so sometimes things can take a while.
Yeah, a range could be done here, but given we don't have the start of the range for when it was behind a flag, I wonder how useful this one really is. For Edge, you could change the |
Yep I saw ranges while a released feature was behind a flag, but those were with specific versions. Although the data that this was behind a flag earlier, even though specific versions are unknown, could be useful for some historical reasons. So should I leave it as it is or create an array? I'll edit Edge data soon. |
I wish we had a clear policy about this, but we haven't come to an agreement on this matter yet, see #3318.
Thank you! |
Yep I like that better. You never know who might need it, and for what bizarre reasons :). The PR should be finished in a few hours. Should I somehow notify you when it's done? |
Thanks for your work and going the extra mile here! |
@Elchi3 done. Note though that I haven't tested the change for Edge, so I'm counting on your data. I will rename the PR to reflect that it touches Edge too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Nice work! 👍
Summarize your changes: Chrome has four more properties from TextMetrics enabled by default since release 77 of desktop, Android, and Webview browsers.
Data: link to resources that verify support information: Chrome Platform Status: New TextMetrics object in canvas says that
actualBoundingBoxLeft
,actualBoundingBoxRight
,actualBoundingBoxAscent
andactualBoundingBoxDescent
are enabled by default since release 77.Data: if you tested something, describe how you tested with details like browser and version:
I made a quick test on Chrome 79 desktop:
It gives an object with the following properties:
Review the results of the linter and fix problems reported (If you need help, please ask in a comment!): done, all green.
Link to related issues or pull requests, if any: haven't found anything related to TextMetrics in Chrome 77.