Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete nodejs data for SharedArrayBuffer #6294

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Complete nodejs data for SharedArrayBuffer #6294

merged 1 commit into from
Jun 15, 2020

Conversation

gilmoreorless
Copy link
Contributor

Part of #6249. This fills in the null value for Node in DataView, and corrects some erroneous false values.

All SharedArrayBuffer support was added in Node 8.10.0. This is mostly reflected in the current data (apart from these corrected values), and backed up by https://node.green and my local testing.

@queengooborg queengooborg added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Jun 13, 2020
Elchi3
Elchi3 approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit b899855 into mdn:master Jun 15, 2020
@gilmoreorless gilmoreorless deleted the nodejs-dataview-sab branch June 16, 2020 11:29
@Elchi3 Elchi3 mentioned this pull request Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilmoreorless @Elchi3 @queengooborg