Sort out AudioTrack and VideoTrack support in Chromium #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
Most of the IDL was added in June 2014 behind a flag: https://chromium.googlesource.com/chromium/src/+/cb9c513a764a62acd2da76e04c3e7ec3ab7e0dfa That was M37 based on the date: https://www.chromium.org/developers/calendar Note that https://storage.googleapis.com/chromium-find-releases-static/cb9.html#cb9c513a764a62acd2da76e04c3e7ec3ab7e0dfa claiming this was added in M45 is wrong because this change happened before Blink was merged into the Chromium tree. The AudioVideoTracks has never been enabled by default. The audioTrack and videoTrack attributes on SourceBuffer were added later, in April/March 2016, behind the same flag: https://chromium.googlesource.com/chromium/src/+/1b3dc5a8202a332891b6aed5d4d4521db0b26261 https://chromium.googlesource.com/chromium/src/+/92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1 These changes were in M51: https://storage.googleapis.com/chromium-find-releases-static/1b3.html#1b3dc5a8202a332891b6aed5d4d4521db0b26261 https://storage.googleapis.com/chromium-find-releases-static/923.html#92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1 The data was mirrored for Edge and Opera. Samsung Internet and WebView don't use flags. Fixes mdn#5781.
foolip
force-pushed
the
chromium-AudioVideoTracks
branch
from
924db00
to
d4d3c20
Compare
foolip
commented
Sep 8, 2020
|
@jpmedley can you review this? I know it's a lot, sorry :) |
jpmedley
suggested changes
Sep 8, 2020
|
@jpmedley can you review again? |
jpmedley
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was M37 based on the date: https://www.chromium.org/developers/calendar
Note that https://storage.googleapis.com/chromium-find-releases-static/cb9.html#cb9c513a764a62acd2da76e04c3e7ec3ab7e0dfa
claiming this was added in M45 is wrong because this change happened
before Blink was merged into the Chromium tree.
The AudioVideoTracks has never been enabled by default.
The audioTrack and videoTrack attributes on SourceBuffer were added
later, in April/March 2016, behind the same flag:
https://chromium.googlesource.com/chromium/src/+/1b3dc5a8202a332891b6aed5d4d4521db0b26261
https://chromium.googlesource.com/chromium/src/+/92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1
These changes were in M51:
https://storage.googleapis.com/chromium-find-releases-static/1b3.html#1b3dc5a8202a332891b6aed5d4d4521db0b26261
https://storage.googleapis.com/chromium-find-releases-static/923.html#92333c0e5ca6b7768e5bcf6d41ff8fc733ebbfc1
The data was mirrored for Edge and Opera. Samsung Internet and WebView
don't use flags.
Fixes #5781.