Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never-supported IDBVersionChangeEvent#setVersion #6934

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

Need to check the webkit-prefixed version had it.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 16, 2020
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 12, 2020

Need to check the webkit-prefixed version had it.

Hey @saschanaz, did you ever check on this?

@saschanaz
Copy link
Contributor Author

No, and maybe we can ignore it as the interface itself was removed long ago, per the current BCD.

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing in Chrome 22 to see if this was present in the webkit-prefixed version. Doesn't look like it was!

@queengooborg queengooborg merged commit 59d1f76 into mdn:master Nov 18, 2020
@saschanaz saschanaz deleted the nosupport-setversion branch November 18, 2020 21:32
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2020

@vinyldarkscratch We need to fix (e.g., delete or archive) pages which lose BCD as a consequence of feature removals before merging. See #6929 (comment). I'll fix this one now, but let's avoid this going forward. Thank you!

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2020

Wait, no. I can't fix this one; redirecting to the parent is pointless, since this feature is the only functional bit of the parent interface. We probably ought to have removed this feature and it's parent and both https://wiki.developer.mozilla.org/en-US/docs/Web/API/IDBVersionChangeRequest and https://wiki.developer.mozilla.org/en-US/docs/Web/API/IDBVersionChangeRequest/setVersion at the same time.

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2020

OK, I've opened #7411 to try to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants